Avoid computing peerDAS info again and again. #14893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
requested review from
kasey,
terencechain and
nisdas
and removed request for
a team
nalepae
force-pushed
the
peerDAS-validator-custody
branch
from
49a91a1 to
b8803aa
Compare
nisdas
reviewed
Feb 10, 2025
| ) | ||
|
|
||
| var ( | ||
| mut sync.Mutex |
There was a problem hiding this comment.
maybe rename the var to indicate why we have the mutex and the cache ?
nisdas
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read commit by commit.
This PR has 4 commits:
helpers.gointo more specific files. (Code move only.)Infofunction retrieving, from a cache if possible, all peerDAS information related to peersInfofunction when possible.Don't be afraid by the diff, which is for the very large part du to the second commit, moving code from a single file big file to multiple specific small files.